lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <874jwu4lc7.fsf@kernel.org> Date: Mon, 26 Sep 2022 10:59:52 +0300 From: Kalle Valo <kvalo@...nel.org> To: Kees Cook <keescook@...omium.org> Cc: Gregory Greenman <gregory.greenman@...el.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Luca Coelho <luciano.coelho@...el.com>, Johannes Berg <johannes.berg@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Miri Korenblit <miriam.rachel.korenblit@...el.com>, Ilan Peer <ilan.peer@...el.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Nathan Errera <nathan.errera@...el.com>, Mordechay Goodstein <mordechay.goodstein@...el.com>, Mike Golant <michael.golant@...el.com>, Ayala Beker <ayala.beker@...el.com>, Avraham Stern <avraham.stern@...el.com>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2] iwlwifi: Track scan_cmd allocation size explicitly Kees Cook <keescook@...omium.org> writes: > In preparation for reducing the use of ksize(), explicitly track the > size of scan_cmd allocations. This also allows for noticing if the scan > size changes unexpectedly. Note that using ksize() was already incorrect > here, in the sense that ksize() would not match the actual allocation > size, which would trigger future run-time allocation bounds checking. > (In other words, memset() may know how large scan_cmd was allocated for, > but ksize() will return the upper bounds of the actually allocated memory, > causing a run-time warning about an overflow.) > > Cc: Gregory Greenman <gregory.greenman@...el.com> > Cc: Kalle Valo <kvalo@...nel.org> > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Eric Dumazet <edumazet@...gle.com> > Cc: Jakub Kicinski <kuba@...nel.org> > Cc: Paolo Abeni <pabeni@...hat.com> > Cc: Luca Coelho <luciano.coelho@...el.com> > Cc: Johannes Berg <johannes.berg@...el.com> > Cc: Emmanuel Grumbach <emmanuel.grumbach@...el.com> > Cc: Miri Korenblit <miriam.rachel.korenblit@...el.com> > Cc: Ilan Peer <ilan.peer@...el.com> > Cc: linux-wireless@...r.kernel.org > Cc: netdev@...r.kernel.org > Signed-off-by: Kees Cook <keescook@...omium.org> Gregory, can I take this directly to wireless-next? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists