linux-hardening - Re: [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210121451.7CEC6637@keescook>
Date:   Wed, 12 Oct 2022 14:51:52 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc:     linux-hardening@...r.kernel.org,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Paramjit Oberoi <pso@...omium.org>,
        Ard Biesheuvel <ardb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] pstore/ram: Move internal definitions out of
 kernel-wide include

On Wed, Oct 12, 2022 at 04:46:44PM -0300, Guilherme G. Piccoli wrote:
> On 11/10/2022 17:01, Kees Cook wrote:
> > Most of the details of the ram backend are entirely internal to the
> > backend itself. Leave only what is needed to instantiate a ram backend
> > in the kernel-wide header.
> > 
> > Cc: Anton Vorontsov <anton@...msg.org>
> > Cc: Colin Cross <ccross@...roid.com>
> > Cc: Tony Luck <tony.luck@...el.com>
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> > ---
> 
> Reviewed-and-tested-by: Guilherme G. Piccoli <gpiccoli@...lia.com>
> 
> Tested by building and booting the kernel - since it's just header file
> rework, guess this is enough right?
> 
> BTW, let me know if you prefer me to respond on the series once or per
> patch Kees (as I'm doing here).

Thanks! Yeah, per-patch is good. :)

-- 
Kees Cook