linux-hardening - Re: [PATCH] pstore/ram: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168375283737.2438356.7396268515330470842.b4-ty@chromium.org>
Date:   Wed, 10 May 2023 14:07:20 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Kees Cook <keescook@...omium.org>, kernel@...gutronix.de,
        Tony Luck <tony.luck@...el.com>, gpiccoli@...lia.com,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] pstore/ram: Convert to platform remove callback returning void

On Sat, 1 Apr 2023 14:00:00 +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore/ram: Convert to platform remove callback returning void
      https://git.kernel.org/kees/c/48f2c681df43

I will send this Linus's way for -rc2. Apologies for the delay!

-- 
Kees Cook