linux-hardening - Re: [PATCH] pstore/ram: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230511061302.bobt65hflutwvuoo@pengutronix.de>
Date:   Thu, 11 May 2023 08:13:02 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Kees Cook <keescook@...omium.org>
Cc:     gpiccoli@...lia.com, Tony Luck <tony.luck@...el.com>,
        kernel@...gutronix.de, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] pstore/ram: Convert to platform remove callback
 returning void

On Wed, May 10, 2023 at 02:07:20PM -0700, Kees Cook wrote:
> On Sat, 1 Apr 2023 14:00:00 +0200, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is (mostly) ignored
> > and this typically results in resource leaks. To improve here there is a
> > quest to make the remove callback return void. In the first step of this
> > quest all drivers are converted to .remove_new() which already returns
> > void.
> > 
> > [...]
> 
> Applied to for-next/pstore, thanks!
> 
> [1/1] pstore/ram: Convert to platform remove callback returning void
>       https://git.kernel.org/kees/c/48f2c681df43
> 
> I will send this Linus's way for -rc2. Apologies for the delay!

Thanks. If you ask me, you don't need to annoy Linus with such a patch
after the merge window. If it goes in for 6.5-rc1 that's fine for me.
There is no urge, still >1000 drivers to convert before I start thinking
about a patch that changes struct platform_driver and so depends on this
conversion.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)