linux-hardening - Re: [PATCH 0/2] pstore: Replace crypto API compression with zlib calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <817D6DDD-EF26-492E-B411-295B9538DF54@kernel.org>
Date:   Tue, 04 Jul 2023 09:08:03 -0700
From:   Kees Cook <kees@...nel.org>
To:     Ard Biesheuvel <ardb@...nel.org>, linux-hardening@...r.kernel.org
CC:     Kees Cook <keescook@...omium.org>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Subject: Re: [PATCH 0/2] pstore: Replace crypto API compression with zlib calls

On July 4, 2023 6:52:09 AM PDT, Ard Biesheuvel <ardb@...nel.org> wrote:
>The pstore layer implements support for compression of kernel log
>output, using a variety of compressions algorithms provided by the
>[deprecated] crypto API 'comp' interface.
>
>This appears to have been somebody's pet project rather than a solution
>to a real problem: the original deflate compression is reasonably fast,
>compressed well and is comparatively small in terms of code footprint,
>and so the flexibility that the crypto API integration provides does
>little more than complicate the code for no reason.
>
>So let's get rid of this complexity, and switch back to zlib deflate
>using the library interface.
>
>Cc: Kees Cook <keescook@...omium.org>
>Cc: "Guilherme G. Piccoli" <gpiccoli@...lia.com>

Thanks for picking this back up, it had fallen down on my to-do list. :)

>
>Ard Biesheuvel (1):
>  pstore: Replace crypto API compression with zlib_deflate library calls
>
>Kees Cook (1):
>  pstore: Remove worst-case compression size logic
>
> fs/pstore/Kconfig    | 100 +-------
> fs/pstore/platform.c | 249 +++++---------------
> 2 files changed, 72 insertions(+), 277 deletions(-)

My favorite kind of patch ratio! :)


-- 
Kees Cook