linux-hardening - Re: [PATCH 2/2] pstore: Replace crypto API compression with zlib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D690FB7B-BE46-4A56-9BDE-AB84652997D3@kernel.org>
Date:   Tue, 04 Jul 2023 09:48:30 -0700
From:   Kees Cook <kees@...nel.org>
To:     Ard Biesheuvel <ardb@...nel.org>, linux-hardening@...r.kernel.org
CC:     Kees Cook <keescook@...omium.org>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Subject: Re: [PATCH 2/2] pstore: Replace crypto API compression with zlib_deflate library calls

On July 4, 2023 6:52:11 AM PDT, Ard Biesheuvel <ardb@...nel.org> wrote:
>@@ -217,10 +220,6 @@ static void allocate_buf_for_compression(void)
> 
> static void free_buf_for_compression(void)
> {
>-	if (IS_ENABLED(CONFIG_PSTORE_COMPRESS) && tfm) {
>-		crypto_free_comp(tfm);
>-		tfm = NULL;
>-	}
> 	kfree(big_oops_buf);
> 	big_oops_buf = NULL;
> 	big_oops_buf_sz = 0;

I think this is missing a free of compress_workspace? Everything else looks great! What kind of testing did you do for this series?


-- 
Kees Cook