linux-hardening - Re: stable-rc: 6.1: gcc-plugins: Reorganize gimple includes for GCC 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2023 08:47:53 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-stable <stable@...r.kernel.org>,
        lkft-triage@...ts.linaro.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        linux-hardening@...r.kernel.org,
        Palmer Dabbelt <palmer@...osinc.com>
Subject: Re: stable-rc: 6.1: gcc-plugins: Reorganize gimple includes for GCC 13

On Fri, 11 Aug 2023 at 02:01, Kees Cook <keescook@...omium.org> wrote:
>
> On Tue, Aug 08, 2023 at 10:57:30AM +0530, Naresh Kamboju wrote:
> > LKFT build plans updated with toolchain gcc-13 and here is the report.
> >
> > Stable rc 6.1 arm64 builds with gcc-13 failed and the bisection is pointing
> > to this as first bad commit,
> >
> > # first fixed commit: [e6a71160cc145e18ab45195abf89884112e02dfb]
> >    gcc-plugins: Reorganize gimple includes for GCC 13
> >
> > Thanks Anders for bisecting this problem against Linux 6.2-rc6.
> >
> > Build errors:
> > ---------------
> > In file included from /builds/linux/scripts/gcc-plugins/gcc-common.h:75,
> >                  from /builds/linux/scripts/gcc-plugins/stackleak_plugin.c:30:
> > /usr/lib/gcc-cross/aarch64-linux-gnu/13/plugin/include/gimple-fold.h:72:32:
> > error: use of enum 'gsi_iterator_update' without previous declaration
> >    72 |                           enum gsi_iterator_update,
> >       |                                ^~~~~~~~~~~~~~~~~~
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
>
> I'm slightly confused by this report.

Sorry. I should have provided full details.

> Is it the build of v6.1 that is failing?

Linux-stable-rc linux.6.1.y failing with gcc-13.

> Commit e6a71160cc14 ("gcc-plugins: Reorganize gimple includes
> for GCC 13") was added in v6.2.

This commit is needed.

>
> I think you're saying you need it backported to the v6.1 stable tree?
> ("First bad commit" is really the first good commit?)

First good commit.
We need to backport this patch for linux.6.1.y

Bisect log:
------
# fixed: [6d796c50f84ca79f1722bb131799e5a5710c4700] Linux 6.2-rc6
# unfixed: [2241ab53cbb5cdb08a6b2d4688feb13971058f65] Linux 6.2-rc5
git bisect start '--term-new=fixed' '--term-old=unfixed' 'v6.2-rc6' 'v6.2-rc5'
# unfixed: [9f4d0bd24e6b42555c02e137763f12c106572e63] Merge tag
'linux-kselftest-fixes-6.2-rc6' of
git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
git bisect unfixed 9f4d0bd24e6b42555c02e137763f12c106572e63
# unfixed: [37d0be6a7d7d6fede952c439f8d8b9d1df5c756f] Merge tag
'gpio-fixes-for-v6.2-rc6' of
git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux
git bisect unfixed 37d0be6a7d7d6fede952c439f8d8b9d1df5c756f
# fixed: [f851453bf19554a42eb480b65436b9500c3cf392] Merge tag
'io_uring-6.2-2023-01-27' of git://git.kernel.dk/linux
git bisect fixed f851453bf19554a42eb480b65436b9500c3cf392
# unfixed: [78020233418518faa72fba11f40e1d53b9e88a2e] bootconfig:
Update MAINTAINERS file to add tree and mailing list
git bisect unfixed 78020233418518faa72fba11f40e1d53b9e88a2e
# unfixed: [e6f2f6ac500c67164f6f6b47299aece579277c14] Merge tag
'i2c-for-6.2-rc6' of
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
git bisect unfixed e6f2f6ac500c67164f6f6b47299aece579277c14
# fixed: [be0d8f48ad97f5b775b0af3310343f676dbf318a] bcache: Silence
memcpy() run-time false positive warnings
git bisect fixed be0d8f48ad97f5b775b0af3310343f676dbf318a
# fixed: [e6a71160cc145e18ab45195abf89884112e02dfb] gcc-plugins:
Reorganize gimple includes for GCC 13
git bisect fixed e6a71160cc145e18ab45195abf89884112e02dfb
# unfixed: [4acf1de35f41549e60c3c02a8defa7cb95eabdf2] kunit: memcpy:
Split slow memcpy tests into MEMCPY_SLOW_KUNIT_TEST
git bisect unfixed 4acf1de35f41549e60c3c02a8defa7cb95eabdf2
# first fixed commit: [e6a71160cc145e18ab45195abf89884112e02dfb]
gcc-plugins: Reorganize gimple includes for GCC 13


- Naresh