lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202310031657.79DC1C570F@keescook> Date: Tue, 3 Oct 2023 16:58:05 -0700 From: Kees Cook <keescook@...omium.org> To: Jens Axboe <axboe@...nel.dk> Cc: Justin Sanders <justin@...aid.com>, Justin Stitt <justinstitt@...gle.com>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Xu Panda <xu.panda@....com.cn>, Yang Yang <yang.yang29@....com> Subject: Re: [PATCH v2] aoe: replace strncpy with strscpy On Tue, Sep 19, 2023 at 05:27:45AM +0000, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `aoe_iflist` is expected to be NUL-terminated which is evident by its > use with string apis later on like `strspn`: > | p = aoe_iflist + strspn(aoe_iflist, WHITESPACE); > > It also seems `aoe_iflist` does not need to be NUL-padded which means > `strscpy` [2] is a suitable replacement due to the fact that it > guarantees NUL-termination on the destination buffer while not > unnecessarily NUL-padding. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@...r.kernel.org > Cc: Kees Cook <keescook@...omium.org> > Cc: Xu Panda <xu.panda@....com.cn> > Cc: Yang Yang <yang.yang29@....com> > Signed-off-by: Justin Stitt <justinstitt@...gle.com> Friendly ping on this patch. Jens, do you want to pick this up? -- Kees Cook
Powered by blists - more mailing lists