lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <169637903951.2062263.17214636672785738003.b4-ty@kernel.dk> Date: Tue, 03 Oct 2023 18:23:59 -0600 From: Jens Axboe <axboe@...nel.dk> To: Justin Sanders <justin@...aid.com>, Justin Stitt <justinstitt@...gle.com> Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Kees Cook <keescook@...omium.org>, Xu Panda <xu.panda@....com.cn>, Yang Yang <yang.yang29@....com> Subject: Re: [PATCH v2] aoe: replace strncpy with strscpy On Tue, 19 Sep 2023 05:27:45 +0000, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `aoe_iflist` is expected to be NUL-terminated which is evident by its > use with string apis later on like `strspn`: > | p = aoe_iflist + strspn(aoe_iflist, WHITESPACE); > > It also seems `aoe_iflist` does not need to be NUL-padded which means > `strscpy` [2] is a suitable replacement due to the fact that it > guarantees NUL-termination on the destination buffer while not > unnecessarily NUL-padding. > > [...] Applied, thanks! [1/1] aoe: replace strncpy with strscpy commit: 5e9b7cfc209b84d135993b8cb75ea383f24b2bba Best regards, -- Jens Axboe
Powered by blists - more mailing lists