lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e2bf83bf-7832-aa1c-bf7a-bbc0d311b25f@embeddedor.com> Date: Wed, 4 Oct 2023 01:41:49 +0200 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Kees Cook <keescook@...omium.org>, James Smart <james.smart@...adcom.com> Cc: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni <kch@...dia.com>, linux-nvme@...ts.infradead.org, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, llvm@...ts.linux.dev Subject: Re: [PATCH] nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by On 10/4/23 01:25, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct nvmet_fc_tgt_queue. > > Cc: James Smart <james.smart@...adcom.com> > Cc: Christoph Hellwig <hch@....de> > Cc: Sagi Grimberg <sagi@...mberg.me> > Cc: Chaitanya Kulkarni <kch@...dia.com> > Cc: linux-nvme@...ts.infradead.org > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook <keescook@...omium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org> Thanks -- Gustavo > --- > drivers/nvme/target/fc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c > index 1ab6601fdd5c..0fa2d658cdeb 100644 > --- a/drivers/nvme/target/fc.c > +++ b/drivers/nvme/target/fc.c > @@ -146,7 +146,7 @@ struct nvmet_fc_tgt_queue { > struct workqueue_struct *work_q; > struct kref ref; > struct rcu_head rcu; > - struct nvmet_fc_fcp_iod fod[]; /* array of fcp_iods */ > + struct nvmet_fc_fcp_iod fod[] __counted_by(sqsize); /* array of fcp_iods */ > } __aligned(sizeof(unsigned long long)); > > struct nvmet_fc_hostport {
Powered by blists - more mailing lists