lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87a74ca5-13fc-f8ec-5e54-66836532ada7@embeddedor.com> Date: Wed, 4 Oct 2023 01:39:16 +0200 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Kees Cook <keescook@...omium.org>, Tony Nguyen <anthony.l.nguyen@...el.com> Cc: Shiraz Saleem <shiraz.saleem@...el.com>, Jakub Kicinski <kuba@...nel.org>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Gurucharan G <gurucharanx.g@...el.com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, llvm@...ts.linux.dev Subject: Re: [PATCH] i40e: Annotate struct i40e_qvlist_info with __counted_by On 10/4/23 01:18, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct i40e_qvlist_info. > > Cc: Tony Nguyen <anthony.l.nguyen@...el.com> > Cc: Shiraz Saleem <shiraz.saleem@...el.com> > Cc: Jakub Kicinski <kuba@...nel.org> > Cc: Jesse Brandeburg <jesse.brandeburg@...el.com> > Cc: Gurucharan G <gurucharanx.g@...el.com> > Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org> > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook <keescook@...omium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org> Thanks -- Gustavo > --- > include/linux/net/intel/i40e_client.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/net/intel/i40e_client.h > index ed42bd5f639f..0aa4411528fc 100644 > --- a/include/linux/net/intel/i40e_client.h > +++ b/include/linux/net/intel/i40e_client.h > @@ -45,7 +45,7 @@ struct i40e_qv_info { > > struct i40e_qvlist_info { > u32 num_vectors; > - struct i40e_qv_info qv_info[]; > + struct i40e_qv_info qv_info[] __counted_by(num_vectors); > }; > >
Powered by blists - more mailing lists