lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 3 Nov 2023 15:23:28 +0000
From: Robin Murphy <>
To: Mark Brown <>, Duje Mihanović
Cc: Michael Turquette <>,
 Stephen Boyd <>, Linus Walleij <>,
 Rob Herring <>,
 Krzysztof Kozlowski <>,
 Conor Dooley <>, Tony Lindgren <>,
 Daniel Mack <>, Haojian Zhuang <>,
 Robert Jarzmik <>, Liam Girdwood
 <>, Jaroslav Kysela <>,
 Takashi Iwai <>, Leo Yan <>,
 Zhangfei Gao <>, Lubomir Rintel <>,
 Catalin Marinas <>, Will Deacon <>,
 Kees Cook <>, Tony Luck <>,
 "Guilherme G . Piccoli" <>,,,,,,,,,,
 ~postmarketos/, Karel Balej <>,
 kernel test robot <>
Subject: Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

On 2023-11-02 3:26 pm, Mark Brown wrote:
> On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote:
>> The SSPA driver currently seems to generate ARM32 assembly, which causes
>> build errors when building a kernel for an ARM64 ARCH_MMP platform.
>> Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support")
>> Reported-by: kernel test robot <>
>>   	tristate "SoC Audio via MMP SSPA ports"
>> -	depends on ARCH_MMP
>> +	depends on ARCH_MMP && ARM
> This isn't a fix for the existing code, AFAICT the issue here is that
> ARCH_MMP is currently only available for arm and presumably something in
> the rest of your series makes it available for arm64.  This would be a
> prerequisite for that patch.
> Please don't just insert random fixes tags just because you can.

FWIW it doesn't even seem to be the right reason either. AFACIT the 
issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which 
depends on ARM, but after patch #8 ARCH_MMP itself will no longer 
necessarily imply ARM. The fact that selecting SND_ARM with unmet 
dependencies also allows SND_ARMAACI to be enabled (which appears to be 
the only thing actually containing open-coded Arm asm) is tangential.


Powered by blists - more mailing lists