linux-hardening - Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc7aaff0-f767-494e-9a3a-40fcacc1674e@sirena.org.uk>
Date: Thu, 2 Nov 2023 15:26:31 +0000
From: Mark Brown <broonie@...nel.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>
Cc: Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Tony Lindgren <tony@...mide.com>, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Leo Yan <leoy@...vell.com>, Zhangfei Gao <zhangfei.gao@...vell.com>,
	Lubomir Rintel <lkundrak@...sk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Kees Cook <keescook@...omium.org>,
	Tony Luck <tony.luck@...el.com>,
	"Guilherme G . Piccoli" <gpiccoli@...lia.com>,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
	alsa-devel@...a-project.org, linux-hardening@...r.kernel.org,
	phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
	Karel Balej <balejk@...fyz.cz>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote:
> The SSPA driver currently seems to generate ARM32 assembly, which causes
> build errors when building a kernel for an ARM64 ARCH_MMP platform.
> 
> Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support")
> Reported-by: kernel test robot <lkp@...el.com>

>  	tristate "SoC Audio via MMP SSPA ports"
> -	depends on ARCH_MMP
> +	depends on ARCH_MMP && ARM

This isn't a fix for the existing code, AFAICT the issue here is that
ARCH_MMP is currently only available for arm and presumably something in
the rest of your series makes it available for arm64.  This would be a
prerequisite for that patch.

Please don't just insert random fixes tags just because you can.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)