lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 03 Nov 2023 17:58:05 +0100
From: Duje Mihanović <>
To: Mark Brown <>, Robin Murphy <>
Cc: Michael Turquette <>,
 Stephen Boyd <>, Linus Walleij <>,
 Rob Herring <>,
 Krzysztof Kozlowski <>,
 Conor Dooley <>, Tony Lindgren <>,
 Daniel Mack <>, Haojian Zhuang <>,
 Robert Jarzmik <>, Liam Girdwood <>,
 Jaroslav Kysela <>, Takashi Iwai <>,
 Leo Yan <>, Zhangfei Gao <>,
 Lubomir Rintel <>, Catalin Marinas <>,
 Will Deacon <>, Kees Cook <>,
 Tony Luck <>,
 "Guilherme G . Piccoli" <>,,,,,,,,,,
 ~postmarketos/, Karel Balej <>,
 kernel test robot <>
Subject: Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64

On Friday, November 3, 2023 4:23:28 PM CET Robin Murphy wrote:
> On 2023-11-02 3:26 pm, Mark Brown wrote:
> > This isn't a fix for the existing code, AFAICT the issue here is that
> > ARCH_MMP is currently only available for arm and presumably something in
> > the rest of your series makes it available for arm64.  This would be a
> > prerequisite for that patch.
> > 
> > Please don't just insert random fixes tags just because you can.
> FWIW it doesn't even seem to be the right reason either. AFACIT the
> issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which
> depends on ARM, but after patch #8 ARCH_MMP itself will no longer
> necessarily imply ARM. The fact that selecting SND_ARM with unmet
> dependencies also allows SND_ARMAACI to be enabled (which appears to be
> the only thing actually containing open-coded Arm asm) is tangential.

I just looked at it again and it looks like no code in sound/soc/pxa/* or 
sound/arm/pxa* depends on AACI in any way. Therefore, I believe that to fix 
this correctly, I would have to remove "select SND_ARM" from sound/soc/pxa/
Kconfig and optionally move the PXA2xx code out of sound/arm/ and into sound/
soc/pxa/. Is this correct? If so, I'd also split that fix into a separate 


Powered by blists - more mailing lists