linux-hardening - Re: [PATCH 4/4] ASoC: topology: Replace fake root_device with kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Dec 2023 10:02:19 +0100
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: davidgow@...gle.com, Rae Moar <rmoar@...gle.com>,
 Brendan Higgins <brendan.higgins@...ux.dev>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Matti Vaittinen <mazziesaccount@...il.com>, Stephen Boyd <sboyd@...nel.org>,
 Shuah Khan <skhan@...uxfoundation.org>, Jonathan Corbet <corbet@....net>,
 Kees Cook <keescook@...omium.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Maxime Ripard <mripard@...nel.org>
Cc: linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 4/4] ASoC: topology: Replace fake root_device with
 kunit_device in tests

On 12/5/2023 8:31 AM, davidgow@...gle.com wrote:
> Using struct root_device to create fake devices for tests is something
> of a hack. The new struct kunit_device is meant for this purpose, so use
> it instead.
> 
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
>   sound/soc/soc-topology-test.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/soc/soc-topology-test.c b/sound/soc/soc-topology-test.c
> index 2cd3540cec04..1d7696e5bffc 100644
> --- a/sound/soc/soc-topology-test.c
> +++ b/sound/soc/soc-topology-test.c
> @@ -10,6 +10,7 @@
>   #include <sound/soc.h>
>   #include <sound/soc-topology.h>
>   #include <kunit/test.h>
> +#include <kunit/device.h>

Nitpick:
Can we add device.h before test.h, to keep it in alphabetical order?

>   
>   /* ===== HELPER FUNCTIONS =================================================== */
>   
> @@ -21,26 +22,20 @@
>    */
>   static struct device *test_dev;
>   
> -static struct device_driver test_drv = {
> -	.name = "sound-soc-topology-test-driver",
> -};
> -
>   static int snd_soc_tplg_test_init(struct kunit *test)
>   {
> -	test_dev = root_device_register("sound-soc-topology-test");
> +	test_dev = kunit_device_register(test, "sound-soc-topology-test");
>   	test_dev = get_device(test_dev);
>   	if (!test_dev)
>   		return -ENODEV;
>   
> -	test_dev->driver = &test_drv;
> -
>   	return 0;
>   }
>   
>   static void snd_soc_tplg_test_exit(struct kunit *test)
>   {
>   	put_device(test_dev);
> -	root_device_unregister(test_dev);
> +	kunit_device_unregister(test, test_dev);
>   }
>   
>   /*
>