linux-hardening - Re: [PATCH] lib/string_choices: Add str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zc0LQ8YAWBwNptBF@smile.fi.intel.com>
Date: Wed, 14 Feb 2024 20:49:39 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jani Nikula <jani.nikula@...el.com>
Cc: Michal Wajdeczko <michal.wajdeczko@...el.com>,
	linux-hardening@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] lib/string_choices: Add str_plural() helper

On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote:
> On Wed, 14 Feb 2024, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote:
> >> On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote:
> >> > Add str_plural() helper to replace existing open implementations
> >> > used by many drivers and help improve future user facing messages.
> >> 
> >> Any user of this, please?
> 
> git grep "\"\" *: *\"s\""

You know what I meant.
Second patch in the series that shows usefulness of the first patch.

...

> >> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@...el.com>
> >> 
> >> > Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >> > Cc: Jani Nikula <jani.nikula@...el.com>
> >> 
> >> Move these Cc to the after '---' line.
> 
> Why?

At bare minimum to reduce noise in the commit message.
If going further, to be environment friendly (no jokes).

-- 
With Best Regards,
Andy Shevchenko