linux-hardening - Re: [PATCH] lib/string_choices: Add str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202402141104.642F85D@keescook>
Date: Wed, 14 Feb 2024 11:07:47 -0800
From: Kees Cook <keescook@...omium.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Jani Nikula <jani.nikula@...el.com>,
	Michal Wajdeczko <michal.wajdeczko@...el.com>,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] lib/string_choices: Add str_plural() helper

On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 14, 2024 at 08:30:53PM +0200, Jani Nikula wrote:
> > On Wed, 14 Feb 2024, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > > On Wed, Feb 14, 2024 at 08:08:16PM +0200, Andy Shevchenko wrote:
> > >> On Wed, Feb 14, 2024 at 05:50:15PM +0100, Michal Wajdeczko wrote:
> > >> > Add str_plural() helper to replace existing open implementations
> > >> > used by many drivers and help improve future user facing messages.
> > >> 
> > >> Any user of this, please?
> > 
> > git grep "\"\" *: *\"s\""
> 
> You know what I meant.
> Second patch in the series that shows usefulness of the first patch.

Or a Coccinelle script that could do some rewrites? But, yes, if you can
include some examples, that would be nice. I think the helper is fine to
add.

> 
> ...
> 
> > >> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@...el.com>
> > >> 
> > >> > Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > >> > Cc: Jani Nikula <jani.nikula@...el.com>
> > >> 
> > >> Move these Cc to the after '---' line.
> > 
> > Why?
> 
> At bare minimum to reduce noise in the commit message.
> If going further, to be environment friendly (no jokes).

I learned the above-the-line CC habit from akpm. But in looking through
recent commit history, this does appear to be the exception now. I'll
need to adjust my own workflow for this too...

-- 
Kees Cook