linux-hardening - Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240617103704.GA767455@linux.ibm.com>
Date: Mon, 17 Jun 2024 16:07:04 +0530
From: Srikar Dronamraju <srikar@...ux.ibm.com>
To: Anjali K <anjalik@...ux.ibm.com>
Cc: mpe@...erman.id.au, linuxppc-dev@...ts.ozlabs.org, npiggin@...il.com,
        naveen@...nel.org, christophe.leroy@...roup.eu, kees@...nel.org,
        gustavoars@...nel.org, linux-hardening@...r.kernel.org,
        vishalc@...ux.ibm.com
Subject: Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying
 to userspace

> Commit 6d07d1cd300f ("usercopy: Restrict non-usercopy caches to size 0")
> requires that only whitelisted areas in slab/slub objects can be copied to
> userspace when usercopy hardening is enabled using CONFIG_HARDENED_USERCOPY.
> Dtl contains hypervisor dispatch events which are expected to be read by
> privileged users. Hence mark this safe for user access.
> Specify useroffset=0 and usersize=DISPATCH_LOG_BYTES to whitelist the
> entire object.
> 
> Co-developed-by: Vishal Chourasia <vishalc@...ux.ibm.com>
> Signed-off-by: Vishal Chourasia <vishalc@...ux.ibm.com>
> Signed-off-by: Anjali K <anjalik@...ux.ibm.com>
> ---
>  arch/powerpc/platforms/pseries/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@...ux.ibm.com>

-- 
Thanks and Regards
Srikar Dronamraju