linux-hardening - Re: [PATCH -next 2/4] tun: Make use of str_disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240831130741.768da6da@kernel.org>
Date: Sat, 31 Aug 2024 13:07:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: <kees@...nel.org>, <andy@...nel.org>, <willemdebruijn.kernel@...il.com>,
 <jasowang@...hat.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <akpm@...ux-foundation.org>,
 <linux-hardening@...r.kernel.org>, <netdev@...r.kernel.org>,
 <linux-mm@...ck.org>
Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper

On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> Use str_disabled_enabled() helper instead of open
> coding the same.

> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 6fe5e8f7017c..29647704bda8 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -3178,7 +3178,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
>  
>  		/* [unimplemented] */
>  		netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n",
> -			   arg ? "disabled" : "enabled");
> +			   str_disabled_enabled(arg));

You don't explain the 'why'. How is this an improvement?
nack on this and 2 similar networking changes you sent