lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5b1b6fbc-6135-47ae-af32-60ef71595666@huawei.com> Date: Mon, 2 Sep 2024 09:27:51 +0800 From: Hongbo Li <lihongbo22@...wei.com> To: Jakub Kicinski <kuba@...nel.org> CC: <kees@...nel.org>, <andy@...nel.org>, <willemdebruijn.kernel@...il.com>, <jasowang@...hat.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>, <akpm@...ux-foundation.org>, <linux-hardening@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-mm@...ck.org> Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper On 2024/9/1 4:07, Jakub Kicinski wrote: > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: >> Use str_disabled_enabled() helper instead of open >> coding the same. > >> diff --git a/drivers/net/tun.c b/drivers/net/tun.c >> index 6fe5e8f7017c..29647704bda8 100644 >> --- a/drivers/net/tun.c >> +++ b/drivers/net/tun.c >> @@ -3178,7 +3178,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd, >> >> /* [unimplemented] */ >> netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", >> - arg ? "disabled" : "enabled"); >> + str_disabled_enabled(arg)); > > You don't explain the 'why'. How is this an improvement? > nack on this and 2 similar networking changes you sent > This just give an example of using lib/string_choices' helper which prevents the function from being removed due to detection of non-use. These helpers are convenient. It's functionally equivalent, this avoids the dispersion of such writing styles( ? XXX : noXXX) everywhere. Thanks, Hongbo
Powered by blists - more mailing lists