linux-hardening - Re: [PATCH] isofs: Annotate struct SL_component with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240902135554.xpeqg724t2hsqx2u@quack3>
Date: Mon, 2 Sep 2024 15:55:54 +0200
From: Jan Kara <jack@...e.cz>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: jack@...e.cz, kees@...nel.org, gustavoars@...nel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] isofs: Annotate struct SL_component with __counted_by()

On Fri 30-08-24 18:49:03, Thorsten Blum wrote:
> Add the __counted_by compiler attribute to the flexible array member
> text to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/isofs/rock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/isofs/rock.h b/fs/isofs/rock.h
> index ee9660e9671c..7755e587f778 100644
> --- a/fs/isofs/rock.h
> +++ b/fs/isofs/rock.h
> @@ -44,7 +44,7 @@ struct RR_PN_s {
>  struct SL_component {
>  	__u8 flags;
>  	__u8 len;
> -	__u8 text[];
> +	__u8 text[] __counted_by(len);
>  } __attribute__ ((packed));
>  
>  struct RR_SL_s {
> -- 
> 2.46.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR