linux-hardening - Re: [PATCH -next 2/4] tun: Make use of str_disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66d5cc19d34c6_613882942a@willemb.c.googlers.com.notmuch>
Date: Mon, 02 Sep 2024 10:30:49 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Andy Shevchenko <andy@...nel.org>, 
 Jakub Kicinski <kuba@...nel.org>
Cc: Hongbo Li <lihongbo22@...wei.com>, 
 kees@...nel.org, 
 willemdebruijn.kernel@...il.com, 
 jasowang@...hat.com, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 akpm@...ux-foundation.org, 
 linux-hardening@...r.kernel.org, 
 netdev@...r.kernel.org, 
 linux-mm@...ck.org
Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper

Andy Shevchenko wrote:
> On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
> > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> > > Use str_disabled_enabled() helper instead of open
> > > coding the same.
> 
> ...
> 
> > >  		netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n",
> > > -			   arg ? "disabled" : "enabled");
> > > +			   str_disabled_enabled(arg));
> > 
> > You don't explain the 'why'. How is this an improvement?
> > nack on this and 2 similar networking changes you sent
> 
> Side opinion: This makes the messages more unified and not prone to typos
> and/or grammatical mistakes. Unification allows to shrink binary due to
> linker efforts on string literals deduplication.

This adds a layer of indirection.

The original code is immediately obvious. When I see the new code I
have to take a detour through cscope to figure out what it does.

To me, in this case, the benefit is too marginal to justify that.