linux-hardening - Re: [PATCH v3][next] tty: tty_buffer: Avoid hundreds of -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025020741-shame-landline-c597@gregkh>
Date: Fri, 7 Feb 2025 10:38:23 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3][next] tty: tty_buffer: Avoid hundreds of
 -Wflex-array-member-not-at-end warnings

On Fri, Feb 07, 2025 at 09:53:30AM +1030, Gustavo A. R. Silva wrote:
> 
> > >   	unsigned int used;
> > >   	unsigned int size;
> > >   	unsigned int commit;
> > > -	unsigned int lookahead;		/* Lazy update on recv, can become less than "read" */
> > > +	unsigned int lookahead; /* Lazy update on recv, can become less than "read" */
> > 
> > Coding style change?
> 
> (Whaa? for some reason your response didn't reach my inbox until today)

Sorry, my email was stuck on my system for a day, my fault.

> It seems I got a bit too proactive.
> 
> What do you think about the rest of the patch?

I agree with Jiri's comments, and overall I like it as a way forward.

thanks,

greg k-h