linux-hardening - Re: [PATCH v2 00/10] lib/string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdeNoz=QoiMF6hK+eJZH2N7+vUm+1-ovmwGAY5NZ_zTqQ@mail.gmail.com>
Date: Tue, 4 Mar 2025 07:57:13 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: Andy Shevchenko <andy@...nel.org>, Kees Cook <kees@...nel.org>, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

On Tue, Mar 4, 2025 at 4:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@...esas.com> wrote:
>
>
> Hi Kees, Andy
>
> This is v2 patch-set of "add new helpers".

First of all, please rebase your series against the top of the Kees'
branch: https://web.git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/hardening.
Also use --base when preparing the patch series.

When you do that, you will note that the helpers now are ordered
alphabetically (which your series doesn't follow). So, you will need
the next version. But wait a bit (2-3 days) before sending it out to
give a chance to others to comment on your series and samples.

> I would like to use string_choices helper to cleanup the code, but it is
> missing some of well used string pair in kernel. This patch-set adds it.
>
> Step1
>         Add new helpers (This patch-set)
> Step2
>         Each driver/framework use new helper
>
> You can see "git diff --stat" of Step2 on last of this mail.
> One note is that it is including the patch which is using only existing
> helper (= not using new helper).

The mentioned patch you can send as is separately.

> I added sample patch of Step2 in this patch-set as [SAMPLE].

> One concern is that it adds "pass/fail", but we can find many similar
> strings, like below. I have choiced "pass/fail" and use it on all cases
> in my local branch (You can see some of them in [SAMPLE].
> I need your opinion
>
>         passed     / failed
>         succeed    / failed
>         success    / failed
>         successful / failed
>         succeeded  / failed
>         worked     / failed

It looks like something with the 'successful' / 'succeeded' needs to be present.

But in general here is the BIG NOTE: some of the strings may be used
in ABI, which must not change them.

-- 
With Best Regards,
Andy Shevchenko