linux-hardening - Re: [PATCH v2 00/10] lib/string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sentnv6u.wl-kuninori.morimoto.gx@renesas.com>
Date: Tue, 4 Mar 2025 06:53:13 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>,
	Kees Cook <kees@...nel.org>,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 00/10] lib/string_choices: Add new helpers

Hi Andy

Thank you for the reply

> First of all, please rebase your series against the top of the Kees'
> branch: Also use --base when preparing the patch series.
> 
> When you do that, you will note that the helpers now are ordered
> alphabetically (which your series doesn't follow). So, you will need
> the next version. But wait a bit (2-3 days) before sending it out to
> give a chance to others to comment on your series and samples.

OK, will post v3 in next week.

> >         passed     / failed
> >         succeed    / failed
> >         success    / failed
> >         successful / failed
> >         succeeded  / failed
> >         worked     / failed
> 
> It looks like something with the 'successful' / 'succeeded' needs to be
> present.
> 
> But in general here is the BIG NOTE: some of the strings may be used
> in ABI, which must not change them.

It is indeed one of my concern.
Not only above, but some drivers are using capital letters at the beginning,
but helper uses all lowercase...

I agree we should not change string if it was used on dev_info() or something.
But I think it can be more flexible if it was used on dev_dbg() ? not sure...
I will indicate it (= the strings might be changed) on the patch in Step2,
and follow each maintainer / reviewer opinion. Is it OK for you ?

But hmm... I will double check the new helper, some of them might not needed
if it was used only on dev_info()...

Thank you for your help !!

Best regards
---
Kuninori Morimoto