linux-hardening - Re: [PATCH] lib/tests: Make FORTIFY_KUNIT_TEST depend on FORTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506021108.3AD999F73@keescook>
Date: Mon, 2 Jun 2025 11:11:28 -0700
From: Kees Cook <kees@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	"Gustavo A . R . Silva" <gustavoars@...nel.org>,
	David Gow <davidgow@...gle.com>, linux-hardening@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/tests: Make FORTIFY_KUNIT_TEST depend on
 FORTIFY_SOURCE

On Mon, Jun 02, 2025 at 04:51:44PM +0200, Geert Uytterhoeven wrote:
> When CONFIG_FORTIFY_SOURCE is not enabled, all fortify tests are
> skipped.  Move this logic from run-time to config-time, to avoid people
> building and running tests that do not do anything.
> 
> This basically reverts commit 1a78f8cb5daac774 ("fortify: Allow KUnit
> test to build without FORTIFY") in v6.9, which was v3 of commit
> a9dc8d0442294b42 ("fortify: Allow KUnit test to build without FORTIFY")
> in v6.5, which was quickly reverted in commit 5e2956ee46244ffb ("Revert
> "fortify: Allow KUnit test to build without FORTIFY"").

Same thing as for randstruct: I want the test to always be available. I
don't want 1a78f8cb5daac reverted.

-Kees

-- 
Kees Cook