linux-hardening - Re: [PATCH] lib/tests: Make RANDSTRUCT_KUNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXN_1zwWuTGYuv4aH57cynsNA8443dbRgp+UTMzdvyLNw@mail.gmail.com>
Date: Mon, 2 Jun 2025 20:14:08 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Kees Cook <kees@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, 
	"Gustavo A . R . Silva" <gustavoars@...nel.org>, David Gow <davidgow@...gle.com>, 
	linux-hardening@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/tests: Make RANDSTRUCT_KUNIT_TEST depend on RANDSTRUCT

Hi Kees,

On Mon, 2 Jun 2025 at 20:08, Kees Cook <kees@...nel.org> wrote:
> On Mon, Jun 02, 2025 at 04:49:51PM +0200, Geert Uytterhoeven wrote:
> > When CONFIG_RANDSTRUCT is not enabled, all randstruct tests are skipped.
> > Move this logic from run-time to config-time, to avoid people building
> > and running tests that do not do anything.
>
> I don't like doing this because it means that looking at CI output means
> I can't tell if the test was not built or if the config was not
> included. I want to always have the test available, but skip the test if
> the config is missing.

So should we drop all dependencies from tests?
Do you want Zorro bus, NuBus, ... tests (assumed we have them) to
be built on all platforms, and "run" on all CIs?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds