linux-hardening - Re: [PATCH 4/8] MIPS: txx9: Replace deprecated strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLGANory-ZVAg2_d@alpha.franken.de>
Date: Fri, 29 Aug 2025 12:25:58 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-hardening@...r.kernel.org, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] MIPS: txx9: Replace deprecated strcpy() with
 strscpy()

On Sun, Aug 17, 2025 at 08:37:14PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/mips/txx9/generic/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c
> index 5dc867ea2c69..03f8a3a95637 100644
> --- a/arch/mips/txx9/generic/setup.c
> +++ b/arch/mips/txx9/generic/setup.c
> @@ -200,7 +200,7 @@ static void __init preprocess_cmdline(void)
>  	static char cmdline[COMMAND_LINE_SIZE] __initdata;
>  	char *s;
>  
> -	strcpy(cmdline, arcs_cmdline);
> +	strscpy(cmdline, arcs_cmdline);
>  	s = cmdline;
>  	arcs_cmdline[0] = '\0';
>  	while (s && *s) {
> @@ -270,7 +270,7 @@ void __init prom_init(void)
>  	preprocess_cmdline();
>  	select_board();
>  
> -	strcpy(txx9_system_type, txx9_board_vec->system);
> +	strscpy(txx9_system_type, txx9_board_vec->system);
>  
>  	txx9_board_vec->prom_init();
>  }
> -- 
> 2.50.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]