linux-hardening - Re: [PATCH] MIPS: Loongson64: Replace deprecated strcpy() with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLGAmDgmfqaSOvaB@alpha.franken.de>
Date: Fri, 29 Aug 2025 12:27:36 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Huacai Chen <chenhuacai@...nel.org>,
	Jiaxun Yang <jiaxun.yang@...goat.com>,
	linux-hardening@...r.kernel.org, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Loongson64: Replace deprecated strcpy() with
 strscpy_pad()

On Tue, Aug 19, 2025 at 12:23:19PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy_pad() instead.
> 
> strscpy_pad() already copies the source strings and zero-pads the tail
> of the destination buffers, making the explicit initializations to zero
> redundant. Remove them to ensure the buffers are only written to once.
> 
> No functional changes intended.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/mips/loongson64/boardinfo.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/mips/loongson64/boardinfo.c b/arch/mips/loongson64/boardinfo.c
> index 8bb275c93ac0..827ab94b98b3 100644
> --- a/arch/mips/loongson64/boardinfo.c
> +++ b/arch/mips/loongson64/boardinfo.c
> @@ -1,17 +1,18 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include <linux/kobject.h>
> +#include <linux/string.h>
>  #include <boot_param.h>
>  
>  static ssize_t boardinfo_show(struct kobject *kobj,
>  			      struct kobj_attribute *attr, char *buf)
>  {
> -	char board_manufacturer[64] = {0};
> +	char board_manufacturer[64];
>  	char *tmp_board_manufacturer = board_manufacturer;
> -	char bios_vendor[64] = {0};
> +	char bios_vendor[64];
>  	char *tmp_bios_vendor = bios_vendor;
>  
> -	strcpy(board_manufacturer, eboard->name);
> -	strcpy(bios_vendor, einter->description);
> +	strscpy_pad(board_manufacturer, eboard->name);
> +	strscpy_pad(bios_vendor, einter->description);
>  
>  	return sprintf(buf,
>  		       "Board Info\n"
> -- 
> 2.50.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]