linux-hardening - Re: [PATCH v10 11/11] scsi: qla2xxx: Fix 2 memcpy field-spanning write issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b17fc45-ba6e-4fb3-9352-a6ec0ae913f2@redhat.com>
Date: Tue, 30 Sep 2025 05:38:35 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: Hannes Reinecke <hare@...e.de>,
 "Gustavo A. R. Silva" <gustavo@...eddedor.com>, kbusch@...nel.org,
 martin.petersen@...cle.com, linux-nvme@...ts.infradead.org,
 linux-scsi@...r.kernel.org
Cc: bgurney@...hat.com, axboe@...nel.dk, emilne@...hat.com,
 gustavoars@...nel.org, hch@....de, james.smart@...adcom.com,
 kees@...nel.org, linux-hardening@...r.kernel.org, njavali@...vell.com,
 sagi@...mberg.me
Subject: Re: [PATCH v10 11/11] scsi: qla2xxx: Fix 2 memcpy field-spanning
 write issue

On 9/26/25 5:29 AM, Hannes Reinecke wrote:
> On 9/26/25 11:00, Gustavo A. R. Silva wrote:
>> Hi,
>>
>> Shouldn't this patch be removed from this series, since it's going to be
>> reverted anyways?
>>
> yes. To my understanding the FPIN patch series has been queued in
> scsi-queue anyway, so it would be better to just send an incremental
> patch on top of that.
> Especially as Martin has already indicated that he will _not_ rebase
> his tree.

This V10 patch series is based on nvme-v18.

I don't see the revert in scsi/6.18/scsi-queue yet

> Best to just send this patch as a stand-alone patch, and then rebase
> any not-yet-upstreamed patchsets on top of that.

I'd prefer to merge this patch with the FPIN-LI patch series.  There is to good way to test this field-spanning write fix w/out the FPIN_LI patches,
and the last time we cherry-picked and merged this fix it only led to confusion.

I think we should keep these together.  I will add Gustavo's new fix to my V11 patch series.

/John

> Cheers,
> 
> Hannes