linux-kernel - Re: [RFC: -mm patch] drivers/char/scx200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44B90063.5070504@bootc.net>
Date:	Sat, 15 Jul 2006 15:49:07 +0100
From:	Chris Boot <bootc@...tc.net>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...l.org>, Jim Cromie <jim.cromie@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC: -mm patch] drivers/char/scx200_gpio.c: make code static

Adrian Bunk wrote:
> This patch makes needlessly global code static.

I don't agree with unexporting scx200_gpio_ops and making the struct static, 
this lets other modules use the scx200_gpio module in a semi-independent way. My 
net48xx LED Class code is going to be modified to use the entries in this struct 
to do its GPIO-twiddling magic, potentially allowing my module to do more than 
just the net48xx Error LED.

> Signed-off-by: Adrian Bunk <bunk@...sta.de>
> 
> ---
> 
>  drivers/char/scx200_gpio.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> --- linux-2.6.18-rc1-mm2-full/drivers/char/scx200_gpio.c.old	2006-07-14 22:31:22.000000000 +0200
> +++ linux-2.6.18-rc1-mm2-full/drivers/char/scx200_gpio.c	2006-07-14 22:31:44.000000000 +0200
> @@ -35,7 +35,7 @@
>  
>  #define MAX_PINS 32		/* 64 later, when known ok */
>  
> -struct nsc_gpio_ops scx200_gpio_ops = {
> +static struct nsc_gpio_ops scx200_gpio_ops = {
>  	.owner		= THIS_MODULE,
>  	.gpio_config	= scx200_gpio_configure,
>  	.gpio_dump	= nsc_gpio_dump,
> @@ -44,7 +44,6 @@
>  	.gpio_change	= scx200_gpio_change,
>  	.gpio_current	= scx200_gpio_current
>  };
> -EXPORT_SYMBOL(scx200_gpio_ops);
>  
>  static int scx200_gpio_open(struct inode *inode, struct file *file)
>  {
> @@ -69,7 +68,7 @@
>  	.release = scx200_gpio_release,
>  };
>  
> -struct cdev scx200_gpio_cdev;  /* use 1 cdev for all pins */
> +static struct cdev scx200_gpio_cdev;  /* use 1 cdev for all pins */
>  
>  static int __init scx200_gpio_init(void)
>  {
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Chris Boot
bootc@...tc.net
http://www.bootc.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/