linux-kernel - Re: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Jul 2006 22:47:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <ak@...e.de>
Cc:	torvalds@...l.org, akpm@...l.org, discuss@...-64.org,
	linux-kernel@...r.kernel.org,
	Chuck Ebbert <76306.1226@...puserve.com>
Subject: Re: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set


* Andi Kleen <ak@...e.de> wrote:

>  unsigned long arch_align_stack(unsigned long sp)
>  {
> -	if (randomize_va_space)
> +	if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
>  		sp -= get_random_int() % 8192;
>  	return sp & ~0xf;

i'm not opposing this patch at all, but didnt the performance problems 
go away when the 0xf was changed to 0x7f?

looks good otherwise.

Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/