lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 18 Jul 2006 13:41:48 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andrew Morton <akpm@...l.org>
CC:	Arjan van de Ven <arjan@...radead.org>, chrisw@...s-sol.org,
	linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org,
	xen-devel@...ts.xensource.com, ak@...e.de, rusty@...tcorp.com.au,
	zach@...are.com, ian.pratt@...source.com,
	Christian.Limpach@...cam.ac.uk
Subject: Re: [RFC PATCH 05/33] Makefile support to build Xen subarch

Andrew Morton wrote:
> @@ -99,6 +103,7 @@ drivers-$(CONFIG_PM)			+= arch/i386/powe
>  
>  CFLAGS += $(mflags-y)
>  AFLAGS += $(mflags-y)
> +CPPFLAGS += $(mflags-y)
>
> This change affects _all_ subarchitectures (by potentially altering their
> CPPFLAGS) and it's rather a mystery why one subarch needs the -Ifoo in its
> CPPFLAGS whereas all the others do not.
>   

The reason is that arch-i386/kernel/vmlinux.lds.S is run through CPP, 
and it includes asm/thread_info.h and asm/page.h, which end up including 
"mach_page.h" (which this patch series introduces).  There is a version 
in both mach-default/mach_page.h and mach-xen/mach_page.h, so the -I is 
necessary for non-Xen sub-arches as well. 

I guess the conservative approach would be to only add this -I for the 
vmlinux.lds target, assuming there are no later compile problems.  On 
the flip-side, would you want C and Asm code getting a different set of 
includes from "manually" preprocessed-files?  I would think you'd want 
either defines/includes at all, or to have them identical.

The CPPFLAGS assignment also appears to make the previous two lines 
redundant, since a_flags and c_flags (which is what actually gets used 
for compilation) end up having CPPFLAGS incorporated into them.

    J

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists