linux-kernel - Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44C143FA.9030808@pobox.com>
Date:	Fri, 21 Jul 2006 17:15:38 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Pekka Enberg <penberg@...helsinki.fi>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	Panagiotis Issaris <takis@...umba.uhasselt.be>,
	linux-kernel@...r.kernel.org, len.brown@...el.com,
	chas@....nrl.navy.mil, miquel@...uba.ar, kkeil@...e.de,
	benh@...nel.crashing.org, video4linux-list@...hat.com,
	rmk+mmc@....linux.org.uk, Neela.Kolli@...enio.com,
	vandrove@...cvut.cz, adaplas@....net, thomas@...ischhofer.net,
	weissg@...nna.at, philb@....org, linux-pcmcia@...ts.infradead.org,
	jkmaline@...hut.fi, paulus@...ba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

Stefan Richter wrote:
> Jeff Garzik wrote:
>> Pekka Enberg wrote:
>>> On 7/21/06, Rolf Eike Beer <eike-kernel@...tec.de> wrote:
>>>>> -     if (!(handle = kmalloc(sizeof(struct input_handle), GFP_KERNEL)))
>>>>> +     handle = kzalloc(sizeof(struct input_handle), GFP_KERNEL);
>>>>> +     if (!handle)
>>>>>               return NULL;
>>>> sizeof(*handle)?
>>> In general, yes. However, some maintainers don't like that, so I would
>>> recommend to keep them as-is unless you get a clear ack from the
>>> maintainer to change it.
> 
> I suggest:
>  - check if "sizeof(type)"->"sizeof(*ptr)" is correct
>  - if yes, change it
>  - do this for all kmalloc + kzalloc in a file you touched, or
>    better yet for all kmalloc + kzalloc in a driver or subsystem you
>    touched

This breaks the rules of standard Linux patches.

The patch should contain ONE logical change.  Any cleanups such as 
sizeof(type) -> sizeof(*ptr) should be in a SEPARATE PATCH.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/