linux-kernel - Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44C14426.9000300@pobox.com>
Date:	Fri, 21 Jul 2006 17:16:22 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Jesper Juhl <jesper.juhl@...il.com>
CC:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	Panagiotis Issaris <takis@...umba.uhasselt.be>,
	linux-kernel@...r.kernel.org, len.brown@...el.com,
	chas@....nrl.navy.mil, miquel@...uba.ar, kkeil@...e.de,
	benh@...nel.crashing.org, video4linux-list@...hat.com,
	rmk+mmc@....linux.org.uk, Neela.Kolli@...enio.com,
	vandrove@...cvut.cz, adaplas@....net, thomas@...ischhofer.net,
	weissg@...nna.at, philb@....org, linux-pcmcia@...ts.infradead.org,
	jkmaline@...hut.fi, paulus@...ba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

Jesper Juhl wrote:
> On 21/07/06, Stefan Richter <stefanr@...6.in-berlin.de> wrote:
>> Jeff Garzik wrote:
>> > Pekka Enberg wrote:
>> >> On 7/21/06, Rolf Eike Beer <eike-kernel@...tec.de> wrote:
>> >>> > -     if (!(handle = kmalloc(sizeof(struct input_handle), 
>> GFP_KERNEL)))
>> >>> > +     handle = kzalloc(sizeof(struct input_handle), GFP_KERNEL);
>> >>> > +     if (!handle)
>> >>> >               return NULL;
>> >>>
>> >>> sizeof(*handle)?
>> >>
>> >> In general, yes. However, some maintainers don't like that, so I would
>> >> recommend to keep them as-is unless you get a clear ack from the
>> >> maintainer to change it.
>>
>> I suggest:
>>  - check if "sizeof(type)"->"sizeof(*ptr)" is correct
>>  - if yes, change it
> [snip]
>>  - better style of the size argument where correct,
> 
> Who says it's "better style" ?
> You can argue that   sizeof(type) is more readable.
> When reading the code you don't have to go lookup the type of ptr in
> sizeof(*ptr)  before you know what type the code is working with.

All the more reason that such changes -- unrelated to kzalloc/kcalloc 
conversion -- should be in a separate patch.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/