linux-kernel - Re: [patch] [resend] Fix swsusp with PNP BIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200607250923.18678.ncunningham@linuxmail.org>
Date:	Tue, 25 Jul 2006 09:23:14 +1000
From:	Nigel Cunningham <ncunningham@...uxmail.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Ondrej Zary <linux@...nbow-software.org>,
	Linux List <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>, Adam Belay <abelay@...ell.com>
Subject: Re: [patch] [resend] Fix swsusp with PNP BIOS

Hi.

On Tuesday 25 July 2006 07:25, Rafael J. Wysocki wrote:
> Hi,
>
> On Monday 24 July 2006 20:28, Ondrej Zary wrote:
> > Hello,
> > swsusp is unable to suspend my machine (DTK FortisPro TOP-5A notebook)
> > with kernel 2.6.17.5 because it's unable to suspend PNP device 00:16
> > (mouse).
> >
> > The problem is in PNP BIOS. pnp_bus_suspend() calls pnp_stop_dev() for
> > the device if the device can be disabled according to pnp_can_disable().
> > The problem is that pnpbios_disable_resources() returns -EPERM if the
> > device is not dynamic (!pnpbios_is_dynamic()) but insert_device() happily
> > sets PNP_DISABLE capability/flag even if the device is not dynamic. So we
> > try to disable non-dynamic devices which will fail.
> > This patch prevents insert_device() from setting PNP_DISABLE if the
> > device is not dynamic and fixes suspend on my system.
>
> Thanks for the patch.
>
> Pavel, what do you think?

Adam is probably a better person to ask. (Added to cc).

Regards,

Nigel

Content of type "application/pgp-signature" skipped