linux-kernel - ntfs: remove unnecessary PG_uptodate check from ntfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0607251542570.2665@sbz-30.cs.Helsinki.FI>
Date:	Tue, 25 Jul 2006 15:43:33 +0300 (EEST)
From:	Pekka J Enberg <penberg@...Helsinki.FI>
To:	aia21@...tab.net
cc:	akpm@...l.irg, linux-kernel@...r.kernel.org
Subject: ntfs: remove unnecessary PG_uptodate check from ntfs_readpage

From: Pekka Enberg <penberg@...helsinki.fi>

The check is not needed because SetPageUptodate is called for locked pages
and callers of ->readpage either explicitly check for PageUptodate or pass
newly allocated pages (see read_cache_pages and page_cache_read).

Cc: Andrew Morton <akpm@...l.org>
Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
---

 fs/ntfs/aops.c |    8 --------
 1 file changed, 8 deletions(-)

Index: 2.6/fs/ntfs/aops.c
===================================================================
--- 2.6.orig/fs/ntfs/aops.c
+++ 2.6/fs/ntfs/aops.c
@@ -410,14 +410,6 @@ static int ntfs_readpage(struct file *fi
 
 retry_readpage:
 	BUG_ON(!PageLocked(page));
-	/*
-	 * This can potentially happen because we clear PageUptodate() during
-	 * ntfs_writepage() of MstProtected() attributes.
-	 */
-	if (PageUptodate(page)) {
-		unlock_page(page);
-		return 0;
-	}
 	vi = page->mapping->host;
 	ni = NTFS_I(vi);
 	/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/