linux-kernel - Re: ntfs: remove unnecessary PG_uptodate check from ntfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0607251500480.2372@hermes-2.csi.cam.ac.uk>
Date:	Tue, 25 Jul 2006 15:03:32 +0100 (BST)
From:	Anton Altaparmakov <aia21@....ac.uk>
To:	Pekka J Enberg <penberg@...Helsinki.FI>
cc:	aia21@...tab.net, akpm@...l.irg, linux-kernel@...r.kernel.org
Subject: Re: ntfs: remove unnecessary PG_uptodate check from ntfs_readpage

Please do not apply this patch or you will see metadata corruption on 
NTFS.

Pekka, given there is a comment saying why this check is necessary, I 
really do not understand how you can claim that it is not...

Best regards,

	Anton

On Tue, 25 Jul 2006, Pekka J Enberg wrote:

> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> The check is not needed because SetPageUptodate is called for locked pages
> and callers of ->readpage either explicitly check for PageUptodate or pass
> newly allocated pages (see read_cache_pages and page_cache_read).
> 
> Cc: Andrew Morton <akpm@...l.org>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
> 
>  fs/ntfs/aops.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> Index: 2.6/fs/ntfs/aops.c
> ===================================================================
> --- 2.6.orig/fs/ntfs/aops.c
> +++ 2.6/fs/ntfs/aops.c
> @@ -410,14 +410,6 @@ static int ntfs_readpage(struct file *fi
>  
>  retry_readpage:
>  	BUG_ON(!PageLocked(page));
> -	/*
> -	 * This can potentially happen because we clear PageUptodate() during
> -	 * ntfs_writepage() of MstProtected() attributes.
> -	 */
> -	if (PageUptodate(page)) {
> -		unlock_page(page);
> -		return 0;
> -	}
>  	vi = page->mapping->host;
>  	ni = NTFS_I(vi);
>  	/*
> 

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/