linux-kernel - Re: [PATCH] OMAP: Add keypad driver #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000607251332ma001b27teaf0f07d6c122362@mail.gmail.com>
Date:	Tue, 25 Jul 2006 16:32:44 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Komal Shah" <komal_shah802003@...oo.com>
Cc:	akpm@...l.org, juha.yrjola@...idboot.com, tony@...mide.com,
	ext-timo.teras@...ia.com, r-woddruff2@...com,
	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OMAP: Add keypad driver #2

On 7/25/06, Komal Shah <komal_shah802003@...oo.com> wrote:
> Andrew/Tony/Richard,
>
> This is a revised patch as per the review comments from the Andrew
> on thread:
>
> http://lkml.org/lkml/2006/7/22/19
>
> Please review it and give me the Ack if looks ok.
>

Hi Komal,

The driver needs to handle failures in input_register_device() and
unwind initialization properly. Also you do not need to do double
negation of the value when calling input_report_key() because it will
do it for you.

Also you might consider setting up keycodetable, keycodesize, etc in
the input device - this way you can change keymap at runtime via
ioctls.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/