linux-kernel - Re: [PATCH] OMAP: Add keypad driver #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Jul 2006 22:17:21 -0700 (PDT)
From:	Komal Shah <komal_shah802003@...oo.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	akpm@...l.org, juha.yrjola@...idboot.com, tony@...mide.com,
	ext-timo.teras@...ia.com, r-woodruff2@...com,
	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OMAP: Add keypad driver #2

--- Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:

> 
> Hi Komal,
> 
> The driver needs to handle failures in input_register_device() and
> unwind initialization properly. Also you do not need to do double
> negation of the value when calling input_report_key() because it will
> do it for you.
> 
> Also you might consider setting up keycodetable, keycodesize, etc in
> the input device - this way you can change keymap at runtime via
> ioctls.

Thanx for the review. I will update the driver and submit to list soon.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/