linux-kernel - Re: [PATCH 2/2] usbhid: HID device simple driver interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Jul 2006 01:54:12 +0200
From:	Arnd Bergmann <arnd.bergmann@...ibm.com>
To:	Josef Sipek <jsipek@....cs.sunysb.edu>
Cc:	liyu <liyu@...ss.com.cn>, LKML <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Peter <peter@...bp.freeserve.co.uk>,
	The Doctor <thedoctor@...dis.homelinux.org>
Subject: Re: [PATCH 2/2] usbhid: HID device simple driver interface

On Wednesday 26 July 2006 18:10, Josef Sipek wrote:
> You should use (hid) instead of hid. Because of how the pre-processor works.
> 

Or, even better, use an inline function instead of a macro whereever
possible.

One more thing, the description for patch 1 can probably be refined
a bit more and put into Documentation/somewhere as a new file.

Regarding the split of the patch, it's usually a bad idea to 
put the header file into a separate patch from its users.
E.g. if someone during debugging tries to revert patch 2 but not
patch 1, he ends up with a broken build.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/