linux-kernel - Re: Bad ext3/nfs DoS bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17608.96.409298.126686@cse.unsw.edu.au>
Date:	Thu, 27 Jul 2006 09:53:04 +1000
From:	Neil Brown <neilb@...e.de>
To:	Eric Sandeen <sandeen@...deen.net>
Cc:	Andrew Morton <akpm@...l.org>, Theodore Tso <tytso@....edu>,
	jack@...e.cz, 20@...ingley.org, marcel@...tmann.org,
	linux-kernel@...r.kernel.org, sct@...hat.com, adilger@...sterfs.com
Subject: Re: Bad ext3/nfs DoS bug

On Wednesday July 26, sandeen@...deen.net wrote:
> > +EXPORT_SYMBOL_GPL(export_iget);
> ...
> > +static struct dentry *ext3_get_dentry(struct super_block *sb, void *vobjp)
> > +{
> > +	__u32 *objp = vobjp;
> > +	unsigned long ino = objp[0];
> > +	__u32 generation = objp[1];
> > +
> > +	if (ino != EXT3_ROOT_INO && ino < EXT3_FIRST_INO(sb))
> > +		return ERR_PTR(-ESTALE);
> > +
> > +	return export_iget(sb, ino, generation);
> > +}
> 
> Hm, with this, ext3.ko has a new dependency on exportfs.ko.  Is that 
> desirable/acceptable?

Drat, you're right.
No, I don't think that is what we want.
I'll do it differently in a day or so.

Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/