linux-kernel - Re: via sata oops on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Jul 2006 13:10:44 -0400
From:	Dave Jones <davej@...hat.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: via sata oops on init

On Sat, Jul 29, 2006 at 07:04:02PM +0200, Johannes Weiner wrote:

 > You jump into loop just to skip it.

You have to. Look at the allocation again. It's in a loop.
The first of which may have succeeded.  Your patch will introduce
a memory leak.

		Dave

 > diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
 > index 386e5f2..064ee85 100644
 > --- a/drivers/scsi/libata-core.c
 > +++ b/drivers/scsi/libata-core.c
 > @@ -5420,7 +5420,7 @@ int ata_device_add(const struct ata_prob
 >  
 >  		ap = ata_host_add(ent, host_set, i);
 >  		if (!ap)
 > -			goto err_out;
 > +			goto err_free_ret;
 >  
 >  		host_set->ports[i] = ap;
 >  		xfer_mode_mask =(ap->udma_mask << ATA_SHIFT_UDMA) |



-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/