linux-kernel - Re: [PATCH 01/12] making the kernel -Wshadow clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200607310141.30354.arnd@arndb.de>
Date:	Mon, 31 Jul 2006 01:41:29 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"Jesper Juhl" <jesper.juhl@...il.com>
Cc:	"Paul Jackson" <pj@....com>, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH 01/12] making the kernel -Wshadow clean - fix mconf

Am Sunday 30 July 2006 20:48 schrieb Jesper Juhl:
> >     up
>
> I'd *love* to change this one - and down() as well - to up_sem() &
> down_sem(). But, making that change would be a pretty major and
> somewhat disruptive api change, so I opted instead to change the local
> variable names. I plan to introduce a sepperate patch set later on
> that adds up_sem()/down_sem() wrappers around up()/down(), deprecate
> the old names and add an entry to feature-removal.txt - but doing it
> now as part of the -Wshadow cleanup would be too much pain.

The path for getting rid of up()/down() is more along the lines
of replacing more semaphores with mutex variables. Once the only
users of up()/down() are those that really rely on counting semaphores,
it becomes much easier to do the change you proposed.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/