linux-kernel - Re: [PATCH 00/12] making the kernel -Wshadow clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0608010816290.10130@yvahk01.tjqt.qr>
Date:	Tue, 1 Aug 2006 08:17:46 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Krzysztof Halasa <khc@...waw.pl>
cc:	Jesper Juhl <jesper.juhl@...il.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>,
	Nikita Danilov <nikita@...sterfs.com>,
	Joe Perches <joe@...ches.com>,
	Martin Waitz <tali@...ingilde.org>,
	Jan-Benedict Glaw <jbglaw@...-owl.de>,
	Christoph Hellwig <hch@...radead.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Valdis Kletnieks <Valdis.Kletnieks@...edu>,
	Sam Ravnborg <sam@...nborg.org>,
	Russell King <rmk@....linux.org.uk>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH 00/12] making the kernel -Wshadow clean - The initial
 step

>> I think it's a good thing that we have to take a little more care when
>> choosing global function and variable names... Take up() for example -
>> in my (very humble) oppinion that is a very bad name for a global
>> function - it clashes too easily with local function and variable
>> names, and a programmer who's not careful may end up calling the
>> global up() when he wants the local and vice versa (a much better name
>> would have been sem_up() - should we change that???).
>
>(authors of (yet) off-tree things would hate us)

Mark up() as deprecated while sem_up() emerges - hey, we even have an
__attribute__(()) for that..


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/