lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20060730105657.GA5830@elf.ucw.cz>
Date:	Sun, 30 Jul 2006 12:56:57 +0200
From:	Pavel Machek <pavel@....cz>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] Begin abstraction of sensitive instructions: asm files

Hi!

> > Abstract sensitive instructions in assembler code, replacing them with
> > macros (which currently are #defined to the native versions).  We use
> > long names: assembler is case-insensitive, so if something goes wrong
> > and macros do not expand, it would assemble anyway.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

> > @@ -76,8 +76,15 @@
> >  NT_MASK		= 0x00004000
> >  VM_MASK		= 0x00020000
> >  
> > +/* These are replaces for paravirtualization */
> > +#define DISABLE_INTERRUPTS		cli
> > +#define ENABLE_INTERRUPTS		sti
> > +#define ENABLE_INTERRUPTS_SYSEXIT	sti; sysexit
> > +#define INTERRUPT_RETURN		iret
> 
> Could we use some less verbose names, like possibly CLI, STI,
> STI_SYSEXIT, IRET ?

Apparently I can't read, it was explained in changelog. Could we still
use something shorter, like perhaps _CLI / _STI / _IRET ?
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ