linux-kernel - Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154370233.8417.11.camel@localhost>
Date:	Mon, 31 Jul 2006 11:23:52 -0700
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Chuck Ebbert <76306.1226@...puserve.com>, sfr@...b.auug.org.au,
	"William A (Andy) Adamson" <andros@...i.umich.edu>
Cc:	Orion Poplawski <orion@...a.nwra.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.

On Mon, 2006-07-31 at 02:21 -0400, Chuck Ebbert wrote:

> static void lease_release_private_callback(struct file_lock *fl)
> {
>         if (!fl->fl_file)
>                 return;
> 
>         f_delown(fl->fl_file);
> =>      fl->fl_file->f_owner.signum = 0;
> }

Why should the lease cleanup code be resetting f_owner.signum? That
looks wrong.

Stephen, I think this line of code predates the CITI changes. Do you
know who added it and why?

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/