linux-kernel - Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060802005157.137dfdde.sfr@canb.auug.org.au>
Date:	Wed, 2 Aug 2006 00:51:57 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Trond Myklebust <trond.myklebust@....uio.no>
Cc:	76306.1226@...puserve.com, andros@...i.umich.edu,
	orion@...a.nwra.com, linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.

On Mon, 31 Jul 2006 11:23:52 -0700 Trond Myklebust <trond.myklebust@....uio.no> wrote:
>
> On Mon, 2006-07-31 at 02:21 -0400, Chuck Ebbert wrote:
> 
> > static void lease_release_private_callback(struct file_lock *fl)
> > {
> >         if (!fl->fl_file)
> >                 return;
> > 
> >         f_delown(fl->fl_file);
> > =>      fl->fl_file->f_owner.signum = 0;
> > }
> 
> Why should the lease cleanup code be resetting f_owner.signum? That
> looks wrong.
> 
> Stephen, I think this line of code predates the CITI changes. Do you
> know who added it and why?

Because when the original code was written, it was only called when we got
a fcntl(F_SETLEASE, F_UNLCK) call.  The code got moved incorrectly and
noone noticed.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/