linux-kernel - Re: use persistent allocation for cursor blinking.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154470660.15540.92.camel@localhost.localdomain>
Date:	Tue, 01 Aug 2006 23:17:40 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dave Jones <davej@...hat.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: use persistent allocation for cursor blinking.

Ar Maw, 2006-08-01 am 14:56 -0400, ysgrifennodd Dave Jones:
> +	static u8 *src=NULL;
> +	static int allocsize=0;

s/=/ = /

> +	if (dsize + sizeof(struct fb_image) != allocsize) {
> +		if (src != NULL)
> +			kfree(src);
> +		allocsize = dsize + sizeof(struct fb_image);
> +
> +		src = kmalloc(allocsize, GFP_ATOMIC);
> +		if (!src)
> +			return -ENOMEM;
> +	}

If the allocation fails we have allocsize = "somesize" and src = NULL.
The next time we enter the if is false and we fall through and Oops

Either check src in the if or set allocsize to something impossible (eg
0) on the error path.

NAK

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/