linux-kernel - Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1ejvzx2dw.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 01 Aug 2006 21:06:19 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Andi Kleen <ak@...e.de>
Cc:	<linux-kernel@...r.kernel.org>, Horms <horms@...ge.net.au>,
	Jan Kratochvil <lace@...kratochvil.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Magnus Damm <magnus.damm@...il.com>,
	Vivek Goyal <vgoyal@...ibm.com>, Linda Wang <lwang@...hat.com>
Subject: Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

Andi Kleen <ak@...e.de> writes:

> "Eric W. Biederman" <ebiederm@...ssion.com> writes:
>>  			}
>> @@ -200,6 +224,178 @@ static void putstr(const char *s)
>>  	outb_p(0xff & (pos >> 1), vidport+1);
>>  }
>>  
>> +static void vid_console_init(void)
>
> Please just use early_printk instead of reimplementing this. 
> I think it should work in this context too.

There is certainly some value in that.  To do that I would
need to refactor early_printk to make it useable.

This comment from one of patches summaries the worst of the problems.

> /* WARNING!!
>  * This code is compiled with -fPIC and it is relocated dynamically
>  * at run time, but no relocation processing is performed.
>  * This means that it is not safe to place pointers in static structures.
>  */

lib/string.c might be useful.  The fact that the functions are not
static slightly concerns me.  I have a vague memory of non-static
functions generating relocations for no good reason.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/